Development/comrpc metadata (#848)

* [Containers] Adjust to API changes * [CONTAINERS] Get the containers working *with* the compositor as well.. * [COMRPC] Give the COMRPC servers a name, so thay are identified for metadata handling. * Update Compositor.cpp * Update Compositor.cpp * [WINDOWS] Fix warnings in windows. --------- Co-authored-by: sebaszm <[email protected]>
rdkcentral · Nov 12, 2024 · 6a30cc3 · 6a30cc3
1 parent ff5586e
commit 6a30cc3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/Compositor/lib/Mesa/Compositor.cpp b/Compositor/lib/Mesa/Compositor.cpp
@@ -144,7 +144,7 @@ namespace Plugin {
                 const std::string& proxyStubPath,
                 Exchange::IComposition::IDisplay* parentInterface,
                 const Core::ProxyType<RPC::InvokeServer>& engine)
-                : RPC::Communicator("Compositor", source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine))
+                : RPC::Communicator(source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine), _T("@Compositor"))
                 , _parentInterface(parentInterface)
             {
                 if (_parentInterface != nullptr) {

diff --git a/NetworkControl/NetworkControlImplementation.cpp b/NetworkControl/NetworkControlImplementation.cpp
@@ -1315,19 +1315,19 @@ namespace Plugin
             if (file.IsValid() == false) {
                 SYSLOG(Logging::Notification, (_T("DNS functionality could NOT be updated [%s]"), _dnsFile.c_str()));
             } else {
-                uint32_t offset = file.Size();
+                uint32_t offset = static_cast<uint32_t>(file.Size());
 		string startMarker((_T("#++SECTION: ")) + _service->Callsign() + '\n');
                 string endMarker((_T("#--SECTION: ")) + _service->Callsign() + '\n');
 
                 if (offset > 0) {
-                    uint32_t start = static_cast<uint32_t>(file.Search(0, reinterpret_cast<const uint8_t*>(startMarker.c_str()), startMarker.length()));
+                    uint32_t start = static_cast<uint32_t>(file.Search(0, reinterpret_cast<const uint8_t*>(startMarker.c_str()), static_cast<uint32_t>(startMarker.length())));
 
                     if (start < file.Size()) {
                         // We found a start marker, see if we have an end marker.
-                        uint32_t end = static_cast<uint32_t>(file.Search(start + startMarker.length(), reinterpret_cast<const uint8_t*>(endMarker.c_str()), endMarker.length()));
+                        uint32_t end = static_cast<uint32_t>(file.Search(start + startMarker.length(), reinterpret_cast<const uint8_t*>(endMarker.c_str()), static_cast<uint32_t>(endMarker.length())));
 
                         if (end < file.Size()) {
-                            end += endMarker.length();
+                            end += static_cast<uint32_t>(endMarker.length());
                             offset -= (end - start);
 
                             if (offset > start) {

diff --git a/Svalbard/CryptographyRPC.cpp b/Svalbard/CryptographyRPC.cpp
@@ -38,7 +38,7 @@ namespace Plugin {
                 CryptographyImplementation* parent,
                 const string& proxyStubPath,
                 const Core::ProxyType<RPC::InvokeServer>& engine)
-                : RPC::Communicator(source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine))
+                : RPC::Communicator(source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine), _T("@Svalbard"))
                 , _parent(*parent)
             {
                 Open(Core::infinite);

diff --git a/examples/OutOfProcessPlugin/OutOfProcessImplementation.cpp b/examples/OutOfProcessPlugin/OutOfProcessImplementation.cpp
@@ -190,7 +190,7 @@ POP_WARNING()
                 Exchange::IBrowser* parentInterface,
                 const string& proxyStubPath,
                 const Core::ProxyType<RPC::InvokeServer> & engine)
-                : RPC::Communicator(source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine))
+                : RPC::Communicator(source, proxyStubPath, Core::ProxyType<Core::IIPCServer>(engine), _T("@OutOfProcessPlugin"))
                 , _parentInterface(parentInterface)
             {
                 Open(Core::infinite);

diff --git a/examples/SimpleCOMRPCServer/SimpleCOMRPCServer.cpp b/examples/SimpleCOMRPCServer/SimpleCOMRPCServer.cpp
@@ -221,7 +221,8 @@ POP_WARNING()
         : RPC::Communicator(
             source, 
             proxyServerPath, 
-            Core::ProxyType<Core::IIPCServer>(engine))
+            Core::ProxyType<Core::IIPCServer>(engine),
+            _T("@SimpleComServer"))
         , _remoteEntry(nullptr)
     {
         // Once the socket is opened the first exchange between client and server is an