This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
added post issue and create gist enhancements #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnevers
suggested changes
Jun 30, 2021
client/src/buttons.ts
Outdated
| @@ -1,6 +1,15 @@ | |||
| import { ExtensionContext } from 'vscode'; | |||
| import * as vscode from 'vscode'; | |||
|
|
|||
| const REACH_COMPILE_S:string = 'Reach Compile'; | |||
| const REACH_COMPILE:string = 'reach.compile'; | |||
| const REACH_RUN_S:string = 'Reach Run'; | |||
There was a problem hiding this comment.
nit: can you separate all the type annotations with spaces? e.g. const REACH_RUN : string =
client/src/extension.ts
Outdated
| const FILE_ASSOCIATIONS:string = 'files.associations'; | ||
| const REACH_FILE_EXT:string = '*.rsh'; | ||
| const JAVASCRIPT:string = 'javascript'; | ||
| const SETTINGS_ROOT:string = `${rootFolder}${path.sep}.vscode/settings.json`; |
There was a problem hiding this comment.
rename WORKSPACE_SETTINGS_PATH
client/src/extension.ts
Outdated
| @@ -30,6 +30,13 @@ var terminal; | |||
| const fs = require('fs'); | |||
| const url = require('url'); | |||
|
|
|||
| const FILE_ASSOCIATIONS:string = 'files.associations'; | |||
| const REACH_FILE_EXT:string = '*.rsh'; | |||
There was a problem hiding this comment.
This is really more than an extension, but a wildcard selector. Maybe REACH_FILE_SELECTOR is a more appropriate name
chrisnevers
suggested changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented post issue and create gist enhancements and adding some stronger typing/cleanup.