Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: site build and deploy #356

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: site build and deploy #356

merged 2 commits into from
Nov 13, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 13, 2024

close #355

Summary by CodeRabbit

  • 新功能
    • 更新了配置文件以支持在 GitHub Actions 中的部署。
  • 文档
    • 更新了 README.md 文件,修改了在线演示链接,明确了 Collapse.Panel 的属性变更,强调了弃用的属性和使用建议。
  • 配置变更
    • 修改了 now.json 中的输出目录配置。

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collapse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:31am

Copy link

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改主要涉及三个文件的配置更新。.dumirc.ts 文件中新增了 basepublicPath 属性,以支持在 GitHub Actions 部署时的基本 URL 设置。README.md 文件更新了组件的文档,特别是关于 Collapse.Panel 属性的弃用和替代建议。最后,now.json 文件中的 distDir 属性也进行了修改,指定了新的输出目录为 .doc

Changes

文件 更改摘要
.dumirc.ts 新增 basepublicPath 属性,基于 GITHUB_ACTIONS 环境变量进行条件赋值。
README.md 更新了组件文档,标记 header 属性为弃用,移除 disabled 属性,增加了对 collapsible 属性的详细说明。
now.json 更新了 distDir 属性,从 "dist" 改为 ".doc"

Assessment against linked issues

Objective Addressed Explanation
确保演示功能正常 (#355) 该PR未直接解决演示功能的问题。

Possibly related PRs

  • feat: improve a11y behavior #354: src/Panel.tsx 文件中关于事件处理和可访问性的更改可能与主PR的配置和部署设置相关,尽管它们并未直接修改相同的文件或属性。

Poem

在兔子洞里忙碌跳,
配置更新真美妙。
新路径指引方向,
文档清晰不再愁。
让演示重现光辉,
兔子欢跳乐逍遥! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (ee5c869) to head (4e711bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           5        5           
  Lines         114      114           
  Branches       43       43           
=======================================
  Hits          113      113           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 14034b7 into master Nov 13, 2024
9 checks passed
@afc163 afc163 deleted the fix/site-deploy branch November 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo is not working
1 participant