Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to @rc-component and update dependencies #1126

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

aojunhao123
Copy link
Contributor

@aojunhao123 aojunhao123 commented Feb 23, 2025

Summary by CodeRabbit

  • Refactor

    • 统一了组件和工具的引用路径,切换到新命名空间以增强模块化和一致性。
  • Chores

    • 更新了包名称、发布脚本及依赖项(包括类型定义和工具版本),优化了项目的构建和发布流程。

本次更新主要聚焦于内部结构和依赖管理的优化,不会对现有功能和用户体验产生影响,同时为未来扩展和维护打下坚实基础。

Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 7:32am

Copy link
Contributor

coderabbitai bot commented Feb 23, 2025

Walkthrough

本次更改主要对组件和工具库的导入路径进行了统一调整。所有从 rc-select 导入的 SelectOption 组件现统一改为从 @rc-component/select 导入。同时,将所有从 rc-util 引入的工具函数和 Hook 修改为从 @rc-component/util 引入。此外,package.json 更新了包名、发布脚本和部分依赖(包括新增依赖和移除旧依赖),同时 tsconfig 和类型声明文件中的路径映射也作了相应调整。这些改动均未改变组件功能和逻辑。

Changes

文件 更改摘要
docs/examples/*.tsx 更新导入语句,将所有从 rc-select 导入的 SelectOption 组件替换为从 @rc-component/select 导入。
package.json 更新包名为 @rc-component/select;调整发布脚本;更新/新增依赖版本(如 @rc-component/trigger 升级、引入 @rc-component/motion@rc-component/util),移除旧依赖。
src/** 更新所有从 rc-util 导入的模块路径为 @rc-component/util,涵盖 Hooks、工具函数、组件和类型声明等。
tests/** 更新测试文件中所有从 rc-util 导入的模块路径为 @rc-component/util,调整相关 mock 和测试工具引用。
tsconfig.json & typings/index.d.ts 更新路径映射及模块声明,将 rc-select 改为 @rc-component/select,同时调整 Children/toArray 模块声明。

Possibly related PRs

Suggested reviewers

  • zombieJ

Poem

我是一只跳跃的小兔子,
在代码森林轻快漫步,
导入路径换了新衣,
旧依赖散落成尘土,
依赖更新带来春风拂面,
愿代码永远鲜活明朗!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6130504 and 8bdb8f4.

📒 Files selected for processing (1)
  • package.json (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
package.json (4)

2-3: 包名称与版本更新
这里将包名称由 "rc-select" 修改为 "@rc-component/select",同时将版本号从旧版本更新为 "1.0.0",符合本次重构和重新发布的策略。


37-37: 发布脚本更新
"prepublishOnly" 脚本从使用 np --yolo --no-publish 改为 npm run compile && rc-np,这反映了对发布工具的调整。请确保 rc-np 在发布流程中能达到预期效果。


52-54: 依赖项更新与新增
"dependencies" 部分,更新了 @rc-component/trigger^3.0.0,并新增了 @rc-component/motion (^1.1.4) 与 @rc-component/util (^1.2.1)。这些更改应有助于组件库的模块化和功能扩展,但建议验证这些依赖在代码中是否正确使用且版本兼容。


60-66: 开发依赖项调整
"devDependencies" 部分,更新了 @rc-component/father-plugin^2.0.2,引入了新工具 @rc-component/np (^1.0.0),同时更新了 @types/react@types/react-dom 的版本为 ^18.3.0。请确保这些更新不会对构建过程和测试流程产生负面影响。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

socket-security bot commented Feb 23, 2025

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (14824f5) to head (8bdb8f4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          39       39           
  Lines        1499     1499           
  Branches      445      445           
=======================================
  Hits         1473     1473           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ self-assigned this Feb 25, 2025
@zombieJ zombieJ merged commit e8096c0 into react-component:master Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants