feat: retire deprecated api #491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
docs/examples/formError.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
概述演练这个拉取请求主要修改了 变更
可能相关的 PR
建议的审阅者
诗歌
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 33 33
Branches 12 12
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/examples/simple.tsx (1)
219-219: 建议更新状态属性名称以保持一致性虽然已正确将
transitionName属性替换为motion属性，但状态中仍使用transitionName作为属性名可能会造成混淆。建议将状态属性名也更新为
motionName：- transitionName: string; + motionName: string; - transitionName: 'rc-tooltip-zoom', + motionName: 'rc-tooltip-zoom', - checked={this.state.transitionName === 'rc-tooltip-zoom'} + checked={this.state.motionName === 'rc-tooltip-zoom'} - motion={{ motionName: this.state.transitionName }} + motion={{ motionName: this.state.motionName }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/examples/formError.tsx(1 hunks)docs/examples/onVisibleChange.tsx(2 hunks)docs/examples/simple.tsx(1 hunks)src/Tooltip.tsx(1 hunks)
🔇 Additional comments (4)
src/Tooltip.tsx (2)
3-3: 导入语句更新以移除已弃用的类型已移除
AnimationType导入，这与移除已弃用的animation属性保持一致。
Line range hint
1-150: 验证是否完全移除了已弃用的属性让我们验证代码库中是否还有任何对已弃用属性的引用。
✅ Verification successful
已确认弃用属性的处理方式符合规范
- 已弃用的属性（overlayStyle、overlayClassName、overlayInnerStyle）都已通过 @deprecated 标记
- 新的替代属性（styles.root、classNames.root、styles.body）已经实现
- transitionName 的使用仅存在于文档示例中
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：检查是否还有任何对已弃用属性的引用 # 搜索 animation 属性的使用 echo "检查 animation 属性的使用：" rg "animation['\"]?\s*[=:]" # 搜索 transitionName 属性的使用 echo "检查 transitionName 属性的使用：" rg "transitionName['\"]?\s*[=:]"Length of output: 475
docs/examples/formError.tsx (1)
37-37: 示例更新使用新的动画 API已正确将
animation属性替换为新的motion属性。docs/examples/onVisibleChange.tsx (1)
40-40: 示例保持一致地更新了动画 API已正确将
animation属性替换为新的motion属性，与其他示例保持一致。
Summary by CodeRabbit
新功能
animation和transitionName属性改为使用更灵活的motion属性重构
animation和transitionName属性文档