-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace TSLint with ESLint and typescript-eslint
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11704066905Details
💛 - Coveralls |
09331f3
to
32b9b6f
Compare
jonkoops
commented
Nov 4, 2024
831386f
to
8e4d0dc
Compare
jonkoops
commented
Nov 4, 2024
jonkoops
commented
Nov 4, 2024
jonkoops
commented
Nov 4, 2024
jonkoops
commented
Nov 4, 2024
@rolandjitsu this one is now ready to be reviewed when you have the time for it. |
12 tasks
Follow up PR under #103 which adds Prettier support. After that I will also expand the ESLint configuration so it has stricter rules enabled, including type-aware linting. |
rolandjitsu
reviewed
Nov 6, 2024
Signed-off-by: Jon Koops <[email protected]>
8e4d0dc
to
5c51373
Compare
rolandjitsu
approved these changes
Nov 6, 2024
🎉 This PR is included in version 3.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Replaces TSLint which is deprecated with ESLint and
typescript-eslint
.Closes #101
Does this PR introduce a breaking change?
No.
Other information
Not applicable.