Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace TSLint with ESLint and typescript-eslint #102

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Nov 4, 2024

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Replaces TSLint which is deprecated with ESLint and typescript-eslint.

Closes #101

Does this PR introduce a breaking change?
No.

Other information
Not applicable.

@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11704066905

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11642392350: 0.0%
Covered Lines: 90
Relevant Lines: 90

💛 - Coveralls

@jonkoops jonkoops force-pushed the replace-tslint branch 2 times, most recently from 831386f to 8e4d0dc Compare November 4, 2024 16:38
package.json Show resolved Hide resolved
@jonkoops jonkoops marked this pull request as ready for review November 4, 2024 16:42
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 4, 2024

@rolandjitsu this one is now ready to be reviewed when you have the time for it.

@jonkoops jonkoops mentioned this pull request Nov 4, 2024
12 tasks
@jonkoops
Copy link
Collaborator Author

jonkoops commented Nov 4, 2024

Follow up PR under #103 which adds Prettier support. After that I will also expand the ESLint configuration so it has stricter rules enabled, including type-aware linting.

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@rolandjitsu rolandjitsu merged commit b387ef8 into react-dropzone:beta Nov 6, 2024
6 checks passed
@jonkoops jonkoops deleted the replace-tslint branch November 6, 2024 13:40
Copy link

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants