chore!: drop support for Internet Explorer #109
Conversation
jonkoops
force-pushed
the
rm-ie-support
branch
from
9bbf6e9 to
22dc601
Compare
jonkoops
changed the title
Pull Request Test Coverage Report for Build 11756318444Details
💛 - Coveralls |
Signed-off-by: Jon Koops <[email protected]> BREAKING CHANGE: drops support for Internet Explorer
jonkoops
force-pushed
the
rm-ie-support
branch
from
22dc601 to
dc52c92
Compare
|
@rolandjitsu this one is ready to go, can I ask you for a review? |
|
There's apparently an IE mode in Edge that's supported until 2029 (see internet explorer 11 has retired)
Not sure what that translates to. There may also be clients out there that are still using IE 🤔 I just thought that's worth mentioning it. |
|
We're already shipping syntax that is no longer supported in Internet Explorer, so this realistically won't be an issue. Also the compatibility mode in Edge is intended to be used only on an allow-list basis for sites that experience compatibility issues, not as a blanket feature to enable on all sites, as that would most certainly cause most sites not to function. |
|
@rolandjitsu any objection against merging this one? I have a couple of PRs that will build off this to resolve the remaining linting issues. |
|
🎉 This PR is included in version 3.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Removes conditional code and tests for Internet Explorer and drops support for it.
Does this PR introduce a breaking change?
Yes, it removes support for Internet Explorer entirely.
Other information
Not relevant.