refactor!: drop CommonJS distribution from package #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11552402651Details
💛 - Coveralls |
jonkoops
force-pushed
the
drop-cjs
branch
8 times, most recently
from
83d4a1a to
3cf4dbe
Compare
BREAKING CHANGE: removes the CommonJS distribution from the package Signed-off-by: Jon Koops <[email protected]>
|
@rolandjitsu this one is good to go as well. I went ahead and moved everything over to ESM, as well as simplifying the TypeScript configurations to the bare minimum. |
This was referenced Oct 28, 2024
rolandjitsu
reviewed
Oct 29, 2024
rolandjitsu
approved these changes
Oct 30, 2024
|
🎉 This PR is included in version 2.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes the CommonJS distribution from the package
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Removes the CommonJS distribution from the package in favor of using the module variant. Documentation has also been cleaned up to reflect these changes.
Does this PR introduce a breaking change?
Yes, the CommonJS distrubution will no longer work, users should replace it with a direct import instead.
Other information
This is a WORK IN PROGRESS and depends on other PRs being merged first (#93).