Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 -- Add static directory to build step #54

Closed
5 tasks done
sthzg opened this issue Aug 17, 2016 · 1 comment
Closed
5 tasks done

V2 -- Add static directory to build step #54

sthzg opened this issue Aug 17, 2016 · 1 comment
Assignees
@sthzg

Comments

@sthzg
Copy link
Member

sthzg commented Aug 17, 2016 •
edited
Loading

Originates from: react-webpack-generators/generator-react-webpack#270

  • add directory src/static
  • provide README in src/static
  • update copy run script to recursively copy the directory to dist/static
  • refactor favicon to be copied via the static dir
  • reference favicon from new location in index.html

Note: in further iterations the build step could be improved by #49, which will allow us to build dynamic/configurable paths to the static/asset/... directories (e.g. when users build apps to be hosted on sub-directories, where src="/static/foo.jpg" would fail).
@sthzg sthzg self-assigned this Aug 17, 2016
sthzg added a commit that referenced this issue Aug 17, 2016
@sthzg
Added static directory to build step #54
1cc21c7 
- add directory `src/static`
- provide README in `src/static`
- update copy run script to recursively copy the directory to
  `dist/static`
- refactor favicon to be copied via the static dir
- reference favicon from new location in `index.html`
@sthzg sthzg mentioned this issue Aug 17, 2016
Merged
sthzg added a commit that referenced this issue Aug 17, 2016
@sthzg
Added static directory to build step (#55)
0cb2072 
- add directory `src/static`
- provide README in `src/static`
- update copy run script to recursively copy the directory to
  `dist/static`
- refactor favicon to be copied via the static dir
- reference favicon from new location in `index.html`

Closes #54
@sthzg sthzg removed the actionable label Aug 17, 2016
@sthzg
Copy link
Member Author

sthzg commented Aug 17, 2016

Closed with #55

@sthzg sthzg closed this as completed Aug 17, 2016
@sthzg sthzg mentioned this issue Aug 19, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sthzg sthzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sthzg