Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static directory to build step #54 #55

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Added static directory to build step #54 #55

merged 1 commit into from
Aug 17, 2016

Conversation

sthzg
Copy link
Member

@sthzg sthzg commented Aug 17, 2016

  • add directory src/static
  • provide README in src/static
  • update copy run script to recursively copy the directory to
    dist/static
  • refactor favicon to be copied via the static dir
  • reference favicon from new location in index.html

- add directory `src/static`
- provide README in `src/static`
- update copy run script to recursively copy the directory to
  `dist/static`
- refactor favicon to be copied via the static dir
- reference favicon from new location in `index.html`
@sthzg
Copy link
Member Author

sthzg commented Aug 17, 2016

Issue: #54

@weblogixx if you don't have any objections we could merge this PR into 2.x. Rethinking the size limit on the url-loader could IMO be a separate issue in its own right.

@weblogixx
Copy link
Member

@sthzg, seems good to me 👍

@sthzg sthzg merged commit 0cb2072 into 2.x Aug 17, 2016
@sthzg sthzg deleted the feature/gh_issue_54 branch August 17, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants