Skip to content

Commit

Permalink
BufferIf: Adjusted API to not collide (#276)
Browse files Browse the repository at this point in the history
If only a pause observable was provided, the method signatures were ambiguous
  • Loading branch information
Noggog authored and RolandPheasant committed Sep 23, 2019
1 parent b27b1b9 commit 7845c64
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/DynamicData/List/ObservableListEx.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1713,7 +1713,7 @@ public static IObservable<IChangeSet<T>> BufferIf<T>([NotNull] this IObservable<
/// <exception cref="System.ArgumentNullException">source</exception>
public static IObservable<IChangeSet<T>> BufferIf<T>([NotNull] this IObservable<IChangeSet<T>> source,
[NotNull] IObservable<bool> pauseIfTrueSelector,
bool intialPauseState = false,
bool intialPauseState,
IScheduler scheduler = null)
{
if (source == null)
Expand Down Expand Up @@ -1742,7 +1742,7 @@ public static IObservable<IChangeSet<T>> BufferIf<T>([NotNull] this IObservable<
/// <exception cref="System.ArgumentNullException">source</exception>
public static IObservable<IChangeSet<T>> BufferIf<T>(this IObservable<IChangeSet<T>> source,
IObservable<bool> pauseIfTrueSelector,
TimeSpan? timeOut = null,
TimeSpan? timeOut,
IScheduler scheduler = null)
{
return BufferIf(source, pauseIfTrueSelector, false, timeOut, scheduler);
Expand All @@ -1762,8 +1762,8 @@ public static IObservable<IChangeSet<T>> BufferIf<T>(this IObservable<IChangeSet
/// <exception cref="System.ArgumentNullException">source</exception>
public static IObservable<IChangeSet<T>> BufferIf<T>(this IObservable<IChangeSet<T>> source,
IObservable<bool> pauseIfTrueSelector,
bool intialPauseState = false,
TimeSpan? timeOut = null,
bool intialPauseState,
TimeSpan? timeOut,
IScheduler scheduler = null)
{
if (source == null)
Expand Down

0 comments on commit 7845c64

Please sign in to comment.