Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: When activities on, the mobile view is missing the Events text #1228

Closed
wants to merge 4 commits into from

Conversation

satishchakma
Copy link
Contributor

@satishchakma satishchakma commented Aug 9, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

bugfix: When activities on, the mobile view is missing the Events text. Now the "Events" text is being shown on mobile menu and also on desktop version.

Fixes #1227

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

reactplay bugfix

@netlify
Copy link

netlify bot commented Aug 9, 2023

‼️ Deploy request for reactplayio rejected.

Name Link
🔨 Latest commit 05f920e

@vercel
Copy link

vercel bot commented Aug 9, 2023

@satishchakma is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas
Copy link
Member

atapas commented Aug 12, 2023

@satishchakma Resolve the conflicts

@satishchakma
Copy link
Contributor Author

Hi @atapas I have resolved the conflicts, I think. The error is gone. Would you kindly have a look? Thank you.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @satishchakma I'm not getting any issues you can see here. Can you please provide clarification on how the issue was resolved without modifying the code?

2023-09-11_18-56-12.mp4

@priyankarpal
Copy link
Member

Can you update me on the progress of this particular issue? @satishchakma

@priyankarpal
Copy link
Member

Since there haven't been any updates, we can move forward with closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: When activities on, the mobile view is missing the "Events" text
3 participants