-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: When activities on, the mobile view is missing the Events text #1228
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 05f920e |
@satishchakma is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
@satishchakma Resolve the conflicts |
Hi @atapas I have resolved the conflicts, I think. The error is gone. Would you kindly have a look? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @satishchakma I'm not getting any issues you can see here. Can you please provide clarification on how the issue was resolved without modifying the code?
2023-09-11_18-56-12.mp4
Can you update me on the progress of this particular issue? @satishchakma |
Since there haven't been any updates, we can move forward with closing this PR. |
Description
bugfix: When activities on, the mobile view is missing the Events text. Now the "Events" text is being shown on mobile menu and also on desktop version.
Fixes #1227
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Screenshots or example output