-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prime sponsor button styling while hovering on it max-width of 800px #1293
fix: prime sponsor button styling while hovering on it max-width of 800px #1293
Conversation
…max width of 800px
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@letscodedanish is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
Hi @letscodedanish! Thanks for your contribution! Is it mobile-friendly? Can you share a GIF/multiple photos to show how does this look on different screen sizes? Also make sure to update this branch with the main |
@joshi-kaushal It's working fine with different screen sizes . video:- bandicam.2023-10-06.10-48-22-434.mp4 |
Please review it @joshi-kaushal . |
@joshi-kaushal please request a review from someone. |
@priyankarpal please have a look on it. |
@letscodedanish please check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/ |
Description
This PR fixes the "Become a Prime sponsor" Button issue. The styling for the "Become a Prime Sponsor" button is not correct.
1 file changed, 3 insertions(+), 4 deletions(-)
Fixes #1268
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested the application after fixing the issue , everything is working fine.
Checklist:
Screenshots or example output
vs-code-cahnges:-
Changed UI