Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheesy Pick-up lines Play #1533

Closed
wants to merge 4 commits into from
Closed

Cheesy Pick-up lines Play #1533

wants to merge 4 commits into from

Conversation

Karna0005
Copy link
Contributor

@Karna0005 Karna0005 commented Oct 4, 2024 •
edited
Loading

Fixes #1534

Pull Request Title: Add Cheesy Lines Randomizer Feature to Display Random Pick-Up Lines

Description:

This pull request addresses the issue of implementing the Cheesy Lines Randomizer feature. The play is a React-based interactive web application that generates random cheesy pick-up lines when a button is clicked.

Key Features:

  1. Randomizer Functionality:

    • A random pick-up line is generated and displayed from a predefined collection when the user clicks the "Get Cheesy Line" button.

  2. React Concepts Used:

    • State Management (useState): Manages the currently displayed pick-up line.
    • Event Handling: The onClick event on the button triggers the randomizer function.
    • Component Rendering: Updates the displayed line in real-time based on the current state.
    • JSX Layout: Structurally displays the lines and button in a clean, interactive design.

  3. UI/UX:

    • A responsive and minimalist interface designed to work on different screen sizes, featuring an eye-catching button and neatly formatted display of pick-up lines.

How to Test:

  1. Clone the repository and switch to the branch containing this feature.
  2. Run npm install to install all dependencies.
  3. Start the application by running npm start.
  4. Interact with the app by clicking the "Get Cheesy Line" button to display random pick-up lines.

Linked Issue:

This pull request addresses and closes Issue #[#1534] - "Add Cheesy Lines Randomizer to Display Random Pick-Up Lines".

Checklist:

  • Implemented the randomizer function.
  • Styled the user interface for an engaging experience.
  • Verified that the randomizer works and updates the displayed line dynamically.
  • Tested responsiveness across different devices and screen sizes.

Feel free to reach out on Discord for further discussions or feedback on this feature!

Screenshots

Screenshot (20)
Screenshot (19)

@Karna0005
Add Cheesylines play and related files
89aa2bb 
- Implemented Cheesylines.js for gameplay functionality
- Created styles.css for the Cheesylines play
- Added Readme.md for documentation on usage and features
- Updated ESLint configuration in .eslintrc.js
@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

👷 Deploy request for reactplayio accepted.

Name Link
🔨 Latest commit 64128b9
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/67035f9b042efc00084eccae

github-actions[bot]
github-actions bot reviewed Oct 4, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Karna0005
Copy link
Contributor Author

I am a Hacktoberfest contributor

@Sachin-chaurasiya
Copy link
Member

I am a Hacktoberfest contributor

Hi @Karna0005, welcome to the community! Thank you for your contribution. Could you please create an issue for this and link it to the PR? Also, it would be great if you could update the PR title with a more descriptive one. If you have any questions, feel free to join our Discord we’d be happy to help!

@Karna0005
Copy link
Contributor Author

Karna0005 commented Oct 5, 2024 •
edited
Loading

Hi Sachin, can you check the code and accept my pull request and add me to the contributor list ?
I have followed all the steps you have mentioned.

@Abhishek-90
Copy link
Contributor

Hi @Karna0005 the PR title is still not reflecting the changes, just Main. Also, we are migrating to TailwindCSS, so instead of using Vanilla CSS, can you use TailwindCSS for styling purposes.

@Karna0005
Copy link
Contributor Author

can you suggest me what should be the pr title..?
ill just change the css from vanilla to tailwind css by the time

@Karna0005
Changes to be committed:
05df6a8 
	modified:   src/plays/cheesylines/Cheesylines.js
	deleted:    src/plays/cheesylines/styles.css
@Karna0005 Karna0005 changed the title Main Main #1534 Oct 5, 2024
@Karna0005 Karna0005 changed the title Main #1534 Main Oct 5, 2024
@Karna0005
Copy link
Contributor Author

Hey,
i have changed the css can you please review the code. or else ill close the current pull request and create another pull request with clear documentation.

@Karna0005
Copy link
Contributor Author

what should i change please tell this is my first contribution

@Karna0005 Karna0005 closed this Oct 6, 2024
@Karna0005 Karna0005 reopened this Oct 6, 2024
@Karna0005 Karna0005 closed this Oct 6, 2024
@Karna0005 Karna0005 reopened this Oct 6, 2024
@Abhishek-90
Copy link
Contributor

can you suggest me what should be the pr title..?

It can be something like, "Cheesy Pick-up lines Play"

@Abhishek-90
Copy link
Contributor

Hey, i have changed the css can you please review the code. or else ill close the current pull request and create another pull request with clear documentation.

Tailwind code seems fine, what say @priyankarpal @Sachin-chaurasiya , shall we merge it?

@Karna0005 Karna0005 changed the title Main "Cheesy Pick-up lines Play" Oct 6, 2024
Sachin-chaurasiya
Sachin-chaurasiya reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

.eslintrc.js Outdated Show resolved Hide resolved
src/plays/cheesylines/Cheesylines.js Show resolved Hide resolved
src/plays/cheesylines/Readme.md Show resolved Hide resolved
src/plays/cheesylines/Readme.md Show resolved Hide resolved
@Sachin-chaurasiya Sachin-chaurasiya changed the title "Cheesy Pick-up lines Play" Cheesy Pick-up lines Play Oct 6, 2024
@Karna0005
Update Readme.md
64128b9 
Signed-off-by: Karunakar S <[email protected]>
@Karna0005
Copy link
Contributor Author

should i raise another pull request, by closing this..?

@Karna0005 Karna0005 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Karna0005 Karna0005

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Add Cheesy Lines Randomizer to Display Random Pick-Up Lines
3 participants
@Karna0005 @Sachin-chaurasiya @Abhishek-90