Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Improved UI of play Typing Speed Test #1558

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

BayajidAlam
Copy link
Contributor

I have update the UI made it more user friendly

issue #1552

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

  • Updated the UI, that gives a user better user experience
  • Showed green when a correct character is typed and red for wrong one
  • Added max WPM(word per minute) in summary
  • Updated the modal
  • Updated README.md

Fixes #1552

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

cover

I have update the UI made it more user friendly

issue reactplay#1552
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 2762940
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6713ac916a6bc000087ba81b
😎 Deploy Preview https://deploy-preview-1558--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal merged commit 81ff5ae into reactplay:main Oct 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Improve UI of the play name Typing Speed Test
2 participants