-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved PlayHeader(#1562) #1568
Conversation
Added collapse button and updated the max-width for the description.
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
@joshua-jinu Can we enhance the button?
|
Sure, any suggestions you have in mind?
|
I have one idea: a black border without a black background. Let's see if this works; if not, we'll use the first one. |
Done @priyankarpal, do check it out and let me know of any required changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
Description
Fixes #1562
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the code locally on my system, manual testing. Checked for functionality and responsiveness across different windows and pages. Ran linter to check for any lint issues.
Checklist:
Screenshots or example output