Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUI refactoring facets screen #501

Merged
merged 18 commits into from
Nov 19, 2024

Conversation

FuzzzzyBoy
Copy link
Contributor

No description provided.

@FuzzzzyBoy FuzzzzyBoy changed the title S UI refactoring facets screen SUI refactoring facets screen Nov 5, 2024
import ReadiumShared

extension Feed {
static var preview: Feed {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickael-menu Perhaps we should move these mocks to the swift-toolkit package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep them here as it's out of scope for the toolkit itself.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FuzzzzyBoy! I made a couple of changes.

import ReadiumShared

extension Feed {
static var preview: Feed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep them here as it's out of scope for the toolkit itself.

@mickael-menu mickael-menu merged commit 1348437 into readium:develop Nov 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants