feat: add support for ordering via tags array
#842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
These changes adds support for ordering pages by the
tagsarray as defined in OAS spec.Per OAS Spec:
The order of the tags can be used to reflect on their order by the parsing tools.The tags on
this.api.tagscomes in in the correct order, however, we create a new arrayArray.from(allTags)with tags added as we parse the file from top down. With these changes, I sort this array against the correctly orderedoasTags. Since the sorting will put tags that exist only at the endpoint level to the front, I also separate them and tack them on to the end of the sorted tags.🧬 QA & Testing
Provide as much information as you can on how to test what you've done.