Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): configure search exclusions #1165

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Feb 3, 2025

🧰 Changes

when pairing with @emilyskuo we noticed a handful of directories/files that i had configured myself but didn't configure for the repo writ large. figured all vscode users could benefit from this config.

🧬 QA & Testing

do the search results properly exclude certain directories/files?

@kanadgupta kanadgupta added the refactor Issues about tackling technical debt label Feb 3, 2025
@kanadgupta kanadgupta marked this pull request as ready for review February 3, 2025 21:37
@@ -0,0 +1,7 @@
{
"search.exclude": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to add these too?

Suggested change
"search.exclude": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.codeActionsOnSave": {
"source.fixAll": "explicit"
},
"editor.formatOnSave": true,
"search.exclude": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i personally don't like those first two but i'll configure prettier yeah

@kanadgupta kanadgupta merged commit ba4936e into next Feb 3, 2025
8 checks passed
@kanadgupta kanadgupta deleted the kanad-2025-02-03/vscode-settings branch February 3, 2025 22:28
kanadgupta added a commit that referenced this pull request Feb 3, 2025
## 🧰 Changes

when pairing with @emilyskuo we noticed a handful of directories/files
that i had configured myself but didn't configure for the repo writ
large. figured all vscode users could benefit from this config.

## 🧬 QA & Testing

do the search results properly exclude certain directories/files?
@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 10.1.2-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants