AtomicBuffer acquire/release methods #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
force-pushed
the
feature/atomicbuffer-release-acquire
branch
from
4820472 to
15ede48
Compare
The AtomicBuffer has release method for every ordered method. So for e.g. a AtomicBUffer.putLongOrdered, there is a putLongRelease. The ordered method will call the release version, so there is a sligth performance penalty. Also acquire get methods have been added that have slightly weaker memory ordering semantics compared to a volatile read. Which could provide more oppertunity for the JIT to do its magic and in theory could give better performance on ISAs with weaker memory models.
pveentjer
force-pushed
the
feature/atomicbuffer-release-acquire
branch
from
15ede48 to
bb70d5d
Compare
pveentjer
force-pushed
the
feature/atomicbuffer-release-acquire
branch
from
1df4f95 to
6876fcc
Compare
pveentjer
force-pushed
the
feature/atomicbuffer-release-acquire
branch
from
6876fcc to
28c0419
Compare
pveentjer
changed the title
pveentjer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AtomicBuffer has a replacement release method for every ordered method. So for e.g. a AtomicBuffer.putLongOrdered, there is a putLongRelease. The methods are identical, but the 'ordered' methods follow an old naming schema.
The ordered method will call the release method, so there is a slight performance penalty. This should encourage users to replace the ordered methods by the release methods.
Also acquire get methods have been added. Typically release puts are combined with acquire gets.
The new naming matches the naming in the Aeron C atomics (they also have acquire/release in the name). This makes it easier for engineers to compare Java and C code.