Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracking of correction positions #5950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented Jan 12, 2025

Reporting of exact positions was already removed in 0.56.0 to collect feedback. So far there haven't been any complaints about the less informative report.

The new message is now like <file_path>: Corrected Trailing Whitespace 7 times. Counting the fixes is easy so I came up with this. The question is whether that's actually useful information ...

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 12, 2025

1 Warning
⚠️ Big PR
18 Messages
📖 Building this branch resulted in a binary size of 29441.74 KiB vs 29488.84 KiB when built on main (-1% smaller).
📖 Linting Aerial with this PR took 1.67 s vs 0.95 s on main (75% slower).
📖 Linting Alamofire with this PR took 1.29 s vs 1.28 s on main (0% slower).
📖 Linting Brave with this PR took 8.67 s vs 8.7 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 5.62 s vs 5.64 s on main (0% faster).
📖 Linting Firefox with this PR took 11.7 s vs 11.76 s on main (0% faster).
📖 Linting Kickstarter with this PR took 10.57 s vs 10.55 s on main (0% slower).
📖 Linting Moya with this PR took 0.55 s vs 0.54 s on main (1% slower).
📖 Linting NetNewsWire with this PR took 2.96 s vs 2.96 s on main (0% slower).
📖 Linting Nimble with this PR took 0.8 s vs 0.82 s on main (2% faster).
📖 Linting PocketCasts with this PR took 8.81 s vs 8.79 s on main (0% slower).
📖 Linting Quick with this PR took 0.45 s vs 0.46 s on main (2% faster).
📖 Linting Realm with this PR took 4.57 s vs 4.58 s on main (0% faster).
📖 Linting Sourcery with this PR took 2.37 s vs 2.36 s on main (0% slower).
📖 Linting Swift with this PR took 4.65 s vs 4.65 s on main (0% slower).
📖 Linting VLC with this PR took 1.26 s vs 1.27 s on main (0% faster).
📖 Linting Wire with this PR took 18.63 s vs 18.69 s on main (0% faster).
📖 Linting WordPress with this PR took 11.65 s vs 11.68 s on main (0% faster).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the correction-positions branch 4 times, most recently from d1ace5c to 416ad52 Compare January 13, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants