Make number of decimal places for float serialisation configurable #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a mess, but I figured I'd see what you think before I go any further...)
Currently serialisation is hardcoded to always use six decimal places, which is often excessive. For my use case, it would be really great to get this down.
Unfortunately this change is very pervasive. And this is probably only about half of it (see
hardcodedPrecision
). I feel I ought to take a step back and try to understand the library architecture better to see if there may be a more elegant solution. Perhaps some refactoring is in order first - for example things likeParseableAttribute
andparseIn
have clearly outgrown their original purpose (not a criticism of you - I see that code predates the fork).