Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Styles #47

wants to merge 3 commits into from

Conversation

georgefst
Copy link
Collaborator

(Based on #45 for now since I can't easily build otherwise)

A first step towards resolving #24. This is enough for my current use cases, since I only want to preserve styles, and not manipulate them.

Note that I'm not very familiar with this library's internal abstractions and may not be using them where appropriate. Also if this is to be merged I should probably add some Haddocks.

The old bound of 300 is not high enough on GHC 9.6.3. A loose bound has been chosen for the sake of simplicity and to prevent further churn.
This is the simplest implementation allowing us to do round-trip processing of SVGs with style tags. The `Style` type could in principle be refined in order to capture the spec more closely.
@lemmih
Copy link
Member

lemmih commented Nov 27, 2023

Hi @georgefst. I'm not actively working on reanimate anymore and won't be reviewing PRs. I can give you write access if you want it.

@georgefst
Copy link
Collaborator Author

Ah I'm sorry to hear that. I'm a big fan of reanimate.

I have no particular interest in maintaining this library in the long run. Though in an ideal world, I'd love to see someone enthusiastic pick it up and merge everything back in to svg-tree.

In the meantime, yes, write access would be great. What about Hackage?

@georgefst
Copy link
Collaborator Author

@lemmih Assuming you're still not interested, I would love to get write access.

@lemmih
Copy link
Member

lemmih commented Oct 25, 2024

@lemmih Assuming you're still not interested, I would love to get write access.

Added you as admin. What's your hackage username?

@lemmih
Copy link
Member

lemmih commented Oct 25, 2024

@lemmih Assuming you're still not interested, I would love to get write access.

Added you as admin. What's your hackage username?

Added someone with your name as a maintainer on Hackage. Hopefully, it is you. :)

@georgefst
Copy link
Collaborator Author

Yep, that was me! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants