Add CSV Viewer to MessageFiles #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CSV Viewer to MessageFiles. Broke out the component as well to accomadate rendering various file types in the future. ** Note, need to add proper icons. ** Also, recommend adding table virtualization for full view of data to improve performance of large files.
❌ Deploy Preview for reachat-storybook failed. Why did it fail? →
|
amcdnl
reviewed
Sep 27, 2024
steppy452
reviewed
Sep 27, 2024
steppy452
reviewed
Sep 27, 2024
steppy452
reviewed
Sep 27, 2024
src/SessionMessages/SessionMessage/MessageFile/ImageFileRenderer.tsx
Outdated
Show resolved
Hide resolved
steppy452
reviewed
Sep 27, 2024
|
@nickhowell6425 thanks for the contribution! i just have some really minor nits + 1 comment around sanitization before i feel this is ready to get merged. but overall, this looks really good |
|
@nickhowell6425 Any updates on this? This would be a very nice feature to have. |
|
Hi, @steppy452. I've applied the changes you asked for. Could you please review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CSV Viewer to MessageFiles. Broke out the component as well to accomadate rendering various file types in the future.
** Note, need to add proper icons.
** Also, recommend adding table virtualization for full view of data to improve performance of large files.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #38
What is the new behavior?
Added CSV Viewer to MessageFiles. Broke out the component as well to accomadate rendering various file types in the future.
Does this PR introduce a breaking change?
Other information