Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing self argument for @app.command decorator #11

Closed
wants to merge 1 commit into from
Closed

Fix missing self argument for @app.command decorator #11

wants to merge 1 commit into from

Conversation

disrupted
Copy link
Contributor

@disrupted disrupted commented Oct 10, 2023 •
edited
Loading

Fixes #8

I believe the outer @wraps decorator is unnecessary since it's already inheriting from typer.Typer

@disrupted disrupted marked this pull request as draft October 10, 2023 15:51
@disrupted
Copy link
Contributor Author

ugh, while this fixes the original issue, this also makes it so that we lose the parameter information of the decorated function...

@disrupted disrupted closed this Oct 10, 2023
rec
rec reviewed Oct 11, 2023
View reviewed changes
Copy link
Owner

@rec rec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what about #12, which might have the best of both worlds?

@disrupted disrupted mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rec rec rec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for type checking with Pyright
2 participants
@disrupted @rec