Pass fully resolved file path to editor

rec · Jan 4, 2024 · 124c1b7 · 124c1b7
1 parent ae2808f
commit 124c1b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/editor/__init__.py b/editor/__init__.py
@@ -90,7 +90,7 @@ def editor(
         if text is not None:
             path.write_text(text)
 
-        cmd = '{} {}'.format(editor, fname)
+        cmd = '{} "{}"'.format(editor, path.resolve())
         runs.call(cmd, **kwargs)
         return path.read_text()
 

diff --git a/test_editor.py b/test_editor.py
@@ -1,3 +1,4 @@
+from pathlib import Path
 import unittest
 from unittest import mock
 
@@ -17,9 +18,10 @@ def test_existing(self, call):
         expected = FILENAME + '\n'
         assert actual == expected
 
-        call.assert_called_once_with('{} {}'.format(EDITOR, FILENAME))
+        filename = Path(FILENAME).resolve()
+        call.assert_called_once_with('{} "{}"'.format(EDITOR, filename))
 
-        actual = editor('X', filename=FILENAME)
+        actual = editor('X', filename=filename)
         expected = 'X'
         assert actual == expected
 
@@ -29,7 +31,8 @@ def test_new(self, call):
         expected = 'X'
         assert actual == expected
 
-        expected = '{} {}'.format(EDITOR, FILENAME)
+        filename = Path(FILENAME).resolve()
+        expected = '{} "{}"'.format(EDITOR, filename)
         call.assert_called_once_with(expected, shell=True)
 
     def test_temp(self, call):