Don't index until we have Sidekiq online

reclaim-the-stack · Sep 12, 2023 · 5ea813c · 5ea813c
1 parent 01a00c9
commit 5ea813c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/models/concerns/elasticsearchable.rb b/app/models/concerns/elasticsearchable.rb
@@ -11,9 +11,11 @@ module Elasticsearchable
     end
   end
 
-  # Override this method to control when the model should be indexed
+  # Override this method to control when the model should be indexed.
+  # By default we skip indexing unless Sidekiq is connected to Redis
+  # to avoid raising errors after commit.
   def should_index?
-    true
+    Sidekiq.redis(&:info) rescue false
   end
 
   def elasticsearch_id

diff --git a/app/models/link.rb b/app/models/link.rb
@@ -15,7 +15,7 @@ def elasticsearch_content
   private
 
   def should_index?
-    state == "success"
+    super && state == "success"
   end
 
   def enqueue_crawl_job