Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MainAPI to get folder prefix #1472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Jan 5, 2025

Rather than having to keep getFolder() and isEpisodeBased in sync, we can automate using a sub-folder if TvType is episode-nased. Also adds some documentation to TvType?.isEpisodeBased() and new TvType.getFolderPrefix()

Rather than having to keep getFolder() and isEpisodeBased in sync, we can automate using a sub-folder if TvType is episode-nased. Also adds some documentation to `TvType?.isEpisodeBased()` and new `TvType.getFolderPrefix()`
@fire-light42
Copy link
Collaborator

I will have to double check this, but if we want to refactor this I would suggest the viewmodel to decide if it is episode based, because it has additional context like is EpisodeResponse.

return this is EpisodeResponse && this.type.isEpisodeBased()

@Luna712
Copy link
Contributor Author

Luna712 commented Jan 9, 2025

I will have to double check this, but if we want to refactor this I would suggest the viewmodel to decide if it is episode based, because it has additional context like is EpisodeResponse.

return this is EpisodeResponse && this.type.isEpisodeBased()

Only LoadResponse version has is EpisodeResponse. I did it like this, at least at the moment just so it kept the exact same behavior as before but I can change it if you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants