Fix php 8.4 compatible code on BitwiseFlagCleaner (#266)

* Fix php 8.4 compatible code BitwiseFlagCleaner ref https://github.com/rectorphp/rector/pull/8990/files#diff-6a4a6fe9ef9b7755c813ac48865f8dd16de0bff4ff4140b9f707b3ffa8e81e58 * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <[email protected]>
rectorphp · Jan 27, 2025 · 6dba109 · 6dba109
1 parent 2e0cde6
commit 6dba109
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php b/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php
@@ -18,7 +18,7 @@ public function __construct(
     ) {
     }
 
-    public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, Expr $expr = null): void
+    public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, ?Expr $expr = null): void
     {
         if ($bitwiseOr->left instanceof BitwiseOr) {
             /** @var BitwiseOr $leftLeft */

diff --git a/src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php b/src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php
@@ -63,7 +63,7 @@ public function __construct(
 
     public function decorateReturn(ClassMethod|Function_|Closure|ArrowFunction $functionLike): void
     {
-        if ($functionLike->returnType === null) {
+        if (! $functionLike->returnType instanceof Node) {
             return;
         }
 
@@ -159,7 +159,7 @@ public function decorateReturnWithSpecificType(
         ClassMethod|Function_|Closure|ArrowFunction $functionLike,
         Type $requireType
     ): bool {
-        if ($functionLike->returnType === null) {
+        if (! $functionLike->returnType instanceof Node) {
             return false;
         }