tests; added for PR #62

recurly · Oct 7, 2013 · 3ee5fec · drewish · Oct 7, 2013 · aheckmann
1 parent ee25c64
commit 3ee5fec
Show file tree

Hide file tree

Showing 6 changed files with 54 additions and 1 deletion.
diff --git a/lib/recurly/response.php b/lib/recurly/response.php
@@ -82,7 +82,7 @@ public function assertValidResponse()
 
   private function parseErrorXml($xml) {
     $dom = new DOMDocument();
-    if (!$dom->loadXML($xml)) return null;
+    if (empty($xml) || !$dom->loadXML($xml)) return null;
 
     $rootNode = $dom->documentElement;
     if ($rootNode->nodeName == 'error')

diff --git a/test/all_tests.php b/test/all_tests.php
@@ -34,5 +34,6 @@ function __construct()
     $this->addFile(__DIR__ . '/recurly/plan_test.php');
     $this->addFile(__DIR__ . '/recurly/subscription_test.php');
     $this->addFile(__DIR__ . '/recurly/transaction_test.php');
+    $this->addFile(__DIR__ . '/recurly/base_test.php');
   }
 }
diff --git a/test/fixtures/accounts/empty.xml b/test/fixtures/accounts/empty.xml
@@ -0,0 +1,3 @@
+HTTP/1.1 200 OK
+Content-Type: application/xml; charset=utf-8
+
diff --git a/test/fixtures/transactions/empty.xml b/test/fixtures/transactions/empty.xml
@@ -0,0 +1,4 @@
+HTTP/1.1 200 OK
+Content-Type: application/xml; charset=utf-8
+
+
diff --git a/test/recurly/base_test.php b/test/recurly/base_test.php
@@ -0,0 +1,34 @@
+
+<?php
+
+class Recurly_BaseTest extends UnitTestCase {
+  // __parseXmlToNewObject($xml, $client)
+  // __parseXmlToUpdateObject($xml)
+
+  function setUp() {
+    $this->client = new MockRecurly_Client();
+    mockRequest($this->client, 'accounts/empty.xml', array('GET', '/accounts/abcdef1234567890'));
+  }
+
+  public function testParsingXMLToNewObject() {
+    try {
+      $account = Recurly_Account::get('abcdef1234567890', $this->client);
+    }
+    catch (Exception $e) {
+      $this->fail("Could not parse empty XML string");
+    }
+
+    $this->assertEqual($account, null);
+  }
+
+  public function testParsingXMLToUpdateObject() {
+    //try {
+      //$out = Recurly_Resource::__parseXmlToUpdateObject('');
+    //}
+    //catch (Exception $e) {
+      //$this->fail("Could not parse empty XML string");
+    //}
+
+    //$this->assertEqual($out, null);
+  }
+}
diff --git a/test/recurly/transaction_test.php b/test/recurly/transaction_test.php
@@ -37,6 +37,17 @@ public function testCreateTransactionFailed()
     }
   }
 
+  public function testCreateTransactionWithEmptyXMLResponse()
+  {
+    $responseFixture = loadFixture(__DIR__ . '/../fixtures/transactions/empty.xml');
+
+    $client = new MockRecurly_Client();
+    $client->returns('request', $responseFixture);
+
+    $transaction = new Recurly_Transaction(null, $client);
+    $transaction->create();
+  }
+
   public function testRefundTransactionPartial()
   {
     mockRequest($this->client,