SubscriptionAddon: fix call to undefined method Recurly_SubscriptionAddOn::__valuesString() #811
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for this pull request, @glaubinix. This looks to have been a missed usage during a previous refactor of the code.
Would you mind updating this pull request to remove the __toString function entirely from the Recurly_SubscriptionAddOn? There is a more robust version defined on Recurly_Base which this class ultimately extends (via Recurly_Resource)
…ddOn::__valuesString()
glaubinix
force-pushed
the
v2-call-to-undefined-method-__valuesString
branch
from
bf5b138
to
e4bb8d8
Compare
|
Sure, done |
Co-authored-by: Douglas Miller <[email protected]>
douglasmiller
approved these changes
May 10, 2024
recurly-integrations
pushed a commit
that referenced
this pull request
Jul 3, 2024
[Full Changelog](2.14.10...2.14.11) **Merged Pull Requests** - GET external_subscription by external_id - V2 PHP [#816](#816) ([paulorbpinho-fullstacklabs](https://github.com/paulorbpinho-fullstacklabs)) - Add taxable address sources to business entity and adjustment [#815](#815) ([ELepolt](https://github.com/ELepolt)) - SubscriptionAddon: fix call to undefined method Recurly_SubscriptionAddOn::__valuesString() [#811](#811) ([glaubinix](https://github.com/glaubinix)) - Added support for `proration_settings` for updating subscriptions [#809](#809) ([csampson](https://github.com/csampson))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Uncaught PHP Exception Error: "Call to undefined method Recurly_SubscriptionAddOn::__valuesString()" at subscription_addon.php line 58