test postal code japan: modify the downloaded URL #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale for this change --- Unable to download `ken_all_rome.zip` for the test of postal code in Japan because the downloaded URL is `ken_all_rome.zip`, not `KEN_ALL_ROME.zip`. It has been modified below. https://www.post.japanpost.jp/zipcode/dl/roman-zip.html What changes are included --- Modify the downloaded URL.
|
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Unable to download
ken_all_rome.zipfor the test of postal code inJapan because the downloaded URL is
ken_all_rome.zip, notKEN_ALL_ROME.zip. It has been modified below.https://www.post.japanpost.jp/zipcode/dl/roman-zip.html
What changes are included
Modify the downloaded URL.