Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bill, in-House group, member and question of the House of Councillors of Japan #181

Merged
merged 8 commits into from
Dec 3, 2023
Merged

Add support for bill, in-House group, member and question of the House of Councillors of Japan #181

merged 8 commits into from
Dec 3, 2023

Conversation

tikkss
Copy link
Contributor

@tikkss tikkss commented Nov 27, 2023

Fixes #143.

@tikkss tikkss force-pushed the add-house-of-councillors-of-japan branch from db0f1fd to bfd262f Compare November 27, 2023 21:33
@tikkss
Copy link
Contributor Author

tikkss commented Nov 27, 2023

Sorry, I've rebased my branch.

@kou
Copy link
Member

kou commented Nov 28, 2023

Could you rebase on master to fix the CI failures?

@tikkss tikkss force-pushed the add-house-of-councillors-of-japan branch from bfd262f to 92c983c Compare November 28, 2023 20:24
@tikkss
Copy link
Contributor Author

tikkss commented Nov 28, 2023

Thanks! I've rebased on master and update expected, so the CI is successfully.

kou
kou approved these changes Dec 2, 2023
View reviewed changes
lib/datasets/house-of-councillor.rb Outdated Show resolved Hide resolved
test/test-house-of-councillor.rb Outdated Show resolved Hide resolved
tikkss and others added 2 commits December 3, 2023 06:36
@tikkss @kou
Put a whitespace
f8f03b7 
Co-authored-by: Sutou Kouhei <[email protected]>
@tikkss
Parse ints
6b7254a 
* `2016、2022` => `[2016, 2022]`
* `2022` => `[2022]`
@tikkss
Copy link
Contributor Author

tikkss commented Dec 2, 2023

Thanks for your review!
I've resolved all. Could you review it again?

@kou kou merged commit 89f9267 into red-data-tools:master Dec 3, 2023
12 checks passed
@kou
Copy link
Member

kou commented Dec 3, 2023

Thanks!

@tikkss tikkss deleted the add-house-of-councillors-of-japan branch December 3, 2023 07:46
@tikkss
Copy link
Contributor Author

tikkss commented Dec 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for bill of the House of Councillors of Japan
2 participants
@tikkss @kou