Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1295:release-4.17 restrict manager resource cache to supplied namespaces #69

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

DFBUGS-1295:release-4.17 restrict manager resource cache to supplied namespaces #69

wants to merge 2 commits into from

Conversation

leelavg
Copy link

@leelavg leelavg commented Jan 7, 2025

manual cherry-pick of #67

leelavg added 2 commits January 7, 2025 12:04
@leelavg
restrict manager resource cache to supplied namespaces
9892195 
always cache resources from operator deployed namespace and provider an
option to user for caching resources from other namespaces via
`WATCH_NAMESPACE` env var with a comma separated namespace values.

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg
bundle: add generated bundle changes
7092951 
Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg leelavg changed the title [DFBUGS-1295] restrict manager resource cache to supplied namespaces [DFBUGS-1295]:release-4.17 restrict manager resource cache to supplied namespaces Jan 7, 2025
@leelavg
Copy link
Author

leelavg commented Jan 7, 2025

/jira refresh

@openshift-ci-robot
Copy link

@leelavg: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leelavg leelavg changed the title [DFBUGS-1295]:release-4.17 restrict manager resource cache to supplied namespaces DFBUGS-1295:release-4.17 restrict manager resource cache to supplied namespaces Jan 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025 •
edited by openshift-ci bot
Loading

@leelavg: This pull request references [Jira Issue DFBUGS-1295](https://issues.redhat.com//browse/DFBUGS-1295), which is invalid:

  • expected the bug to target the "odf-4.17.2" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

manual cherry-pick of #67

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leelavg
Copy link
Author

leelavg commented Jan 7, 2025

/hold
till next patch window opens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leelavg @openshift-ci-robot