inventory file update : jdk or oathtool #4348
Open
+60
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manisha-reddem
requested review from
mkasturi18,
ckulal,
TejasC88 and
a team
as code owners
psathyan
reviewed
Jan 3, 2025
psathyan
previously requested changes
Jan 3, 2025
manisha-reddem
force-pushed
the
feature/rgw
branch
from
5d2d385 to
f1f7013
Compare
manisha-reddem
force-pushed
the
feature/rgw
branch
from
f1f7013 to
a214d01
Compare
manisha-reddem
added
DNM
manisha-reddem
force-pushed
the
feature/rgw
branch
from
a214d01 to
201c3d7
Compare
openshift-ci
bot
removed
the
lgtm
|
/gtm |
|
/lgtm |
psathyan
reviewed
Jan 24, 2025
tests/rgw/sanity_rgw.py
Outdated
| pkgs = " ".join(extra_pkgs) | ||
| package_path = "/root/rgw_rpms" | ||
| for pkg in extra_pkgs: | ||
| pkgs_str = f"{package_path}/{pkg}.rpm" |
There was a problem hiding this comment.
This would have only the last package. I think you want to do
pkgs_str += "{package_path/{pkg}.rpm "
There was a problem hiding this comment.
pkgs_str = " ".join([ f"/root/rgw_rpms/{pkg}.rpm" for pkg in extra_pkgs])
|
/lgtm cancel |
openshift-ci
bot
removed
the
lgtm
Signed-off-by: Reddem Manisha <[email protected]>
manisha-reddem
force-pushed
the
feature/rgw
branch
from
201c3d7 to
4314975
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manisha-reddem, psathyan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize package versions (e.g., JDK, oathtool) in an inventory to simplify updates across suites.
log: http://magna002.ceph.redhat.com/ceph-qe-logs/mreddem/cephci-run-BLWG2P/Test_BucketNotification_with_users_in_same_tenant_and_different_tenant_0.log - for jdk package
log: http://magna002.ceph.redhat.com/ceph-qe-logs/mreddem/cephci-run-IP5QZM/multipart_versioned_object_deletion_with_mfa_token_0.log - for oathtool package
issue: https://issues.redhat.com/browse/RHCEPHQE-16965