Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Automation:CEPH-83595961 #4359

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

chaitanyadommeti
Copy link

Description

Success log: http://magna002.ceph.redhat.com/ceph/cephci-jenkins/cephci-run-WC9LMF/

Copy link
Contributor

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good.

suites/squid/rbd/tier-3_rbd_migration.yaml Show resolved Hide resolved
sunilangadi2
sunilangadi2 previously approved these changes Jan 9, 2025
@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 9, 2025
@sunilangadi2 sunilangadi2 self-requested a review January 13, 2025 11:37
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 17, 2025
@chaitanyadommeti
Copy link
Author

chaitanyadommeti commented Jan 17, 2025

Success log after implementing review comments:
http://magna002.ceph.redhat.com/ceph/cephci-jenkins/cephci-run-1L1UNZ/

Signed-off-by: Chaitanya Dommeti <[email protected]>
@chaitanyadommeti
Copy link
Author

Success log after review comment implementation: https://magna002.ceph.redhat.com/ceph/cephci-jenkins/cephci-run-STD4K1/

Copy link
Contributor

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 21, 2025
Copy link
Contributor

@Manohar-Murthy Manohar-Murthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaitanyadommeti, Manohar-Murthy, sunilangadi2

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit d918097 into red-hat-storage:main Jan 24, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Add this label when the PR is good to be merged RBD Rados Bock Device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants