Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging volume mgmt test cases #4375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Merging volume mgmt test cases #4375

wants to merge 2 commits into from
+732 −837

Conversation

julpark-rh
Copy link
Contributor

Description

http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-OH885L

Merging 3 volume related test cases.

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

@julpark-rh julpark-rh added the Ceph-FS Ceph File System label Jan 15, 2025
Manimaran-MM
Manimaran-MM reviewed Jan 15, 2025
View reviewed changes
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Outdated Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Outdated Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_volume_scenarios.py Outdated Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_subvol_idempotence_earmark.py Outdated Show resolved Hide resolved
tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_rename_earmark_subvolume.py Show resolved Hide resolved
@julpark-rh julpark-rh force-pushed the jan14 branch 7 times, most recently from 39587b4 to c099952 Compare January 17, 2025 22:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

"This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes?"

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julpark-rh, sumabai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 24, 2025

"This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes?"

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

psathyan
psathyan reviewed Jan 24, 2025
View reviewed changes
tests/cephfs/cephfs_utilsV1.py
@@ -5677,3 +5677,40 @@ def validate_dicts(self, dicts, keys_to_check):
log.error(f"Key '{key}' mismatch: Values = {values}")
return False
return True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should start splitting this file into smaller pieces. Maintenance is going to be hard if we continue to keep adding more and more methods.

AmarnatReddy
AmarnatReddy reviewed Jan 24, 2025
View reviewed changes
suites/squid/cephfs/tier-2_file-dir-lay_vol-mgmt_nfs.yaml
@@ -499,4 +499,10 @@ tests:
module: cephfs_vol_management.cephfs_vol_mgmt_test_volume.py
polarion-id: CEPH-83604097
desc: Basic info validation after volume creation and deletion
abort-on-fail: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this as false as other test cases will be skipped if this test fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manimaran-MM Manimaran-MM Manimaran-MM left review comments

@AmarnatReddy AmarnatReddy AmarnatReddy left review comments

@psathyan psathyan psathyan left review comments

@sumabai sumabai sumabai approved these changes

@neha-gangadhar neha-gangadhar Awaiting requested review from neha-gangadhar neha-gangadhar is a code owner

@hkadam134 hkadam134 Awaiting requested review from hkadam134

At least 1 approving review is required to merge this pull request.

Assignees

@sumabai sumabai

Labels
Ceph-FS Ceph File System lgtm Add this label when the PR is good to be merged needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@julpark-rh @openshift-merge-robot @psathyan @AmarnatReddy @sumabai @Manimaran-MM