Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding volume info validations #4379

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

AmarnatReddy
Copy link
Contributor

Description

Adding volume info validations

Scenarios for Volume Info Validation with Data Write:

1. Verify Volume Info Details Without Any Data
2. Create Subvolumes and Validate Usage Details
3. Mount Subvolumes, Write Data, and Validate Usage
4. Create Subvolume Group and Subvolumes, Validate Usage Details
5. Delete Subvolumes and Validate Usage During Deletion

Logs:
With erasure: http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-G5H6NB/
without erasure : http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-TWL5CW/

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

@neha-gangadhar
Copy link
Contributor

@AmarnatReddy Are we updating any existing polarion testcase? or adding a new one for all volume management scenarios?

@AmarnatReddy
Copy link
Contributor Author

@AmarnatReddy Are we updating any existing polarion testcase? or adding a new one for all volume management scenarios?

We need a new test to cover volume info command.

@Manimaran-MM
Copy link
Contributor

@AmarnatReddy Are we updating any existing polarion testcase? or adding a new one for all volume management scenarios?

We need a new test to cover volume info command.

@AmarnatReddy We have an existing TC which covers volume info without data write. If possible can we extend the same TC?
https://polarion.engineering.redhat.com/polarion/#/project/CEPH/workitem?id=CEPH-83604097

@AmarnatReddy AmarnatReddy force-pushed the volume_info branch 6 times, most recently from 546d88d to bf9e4f1 Compare January 28, 2025 14:42
@hkadam134
Copy link
Contributor

Amar,

Can't this be included in our common file for all cephfs volume-related operations instead of creating a new file ?

  • test:
    name: CephFS Volume Operations
    module: cephfs_vol_management.cephfs_vol_mgmt_test_volume.py
    polarion-id: CEPH-83604097
    desc: Test for validating all CephFS Volume Operations
    abort-on-fail: false

@AmarnatReddy
Copy link
Contributor Author

Amar,

Can't this be included in our common file for all cephfs volume-related operations instead of creating a new file ?

  • test:
    name: CephFS Volume Operations
    module: cephfs_vol_management.cephfs_vol_mgmt_test_volume.py
    polarion-id: CEPH-83604097
    desc: Test for validating all CephFS Volume Operations
    abort-on-fail: false

Hi Hemanth,
I reviewed the cephfs_vol_mgmt_test_volume.py file, and I noticed that it primarily focuses on verifying commands and their outputs. However, in my case requires additional steps, such as mounting the volume, writing data, and validating the usage.
So only created a separate test case

@@ -482,3 +482,9 @@ tests:
polarion-id: CEPH-83604978
desc: volume rename, subvolume earmark, subvolumegroup idempotence scenarios
abort-on-fail: false
- test:
name: vol_info
module: cephfs_vol_management.cephfs_vol_info.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only valid for squid? Can we add them to reef and quincy too?

@AmarnatReddy AmarnatReddy force-pushed the volume_info branch 2 times, most recently from f790f54 to 41b9893 Compare January 29, 2025 11:17
@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 30, 2025
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmarnatReddy, Manimaran-MM

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 295ba69 into red-hat-storage:main Jan 30, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Add this label when the PR is good to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants