Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cephci V3] remove redundent testcase from multiple place #4380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anrao19
Copy link
Contributor

@anrao19 anrao19 commented Jan 16, 2025

Description

Pr to avoid redundant test cases in multiple places and multisite setup for verification then only include that test case in multisite execution

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

@anrao19 anrao19 added RGW Rados Gateway tfa-issue-fix TFA automation issue fix labels Jan 16, 2025
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anrao19 anrao19 requested a review from a team January 16, 2025 04:39
@@ -377,17 +377,6 @@ tests:
command: start
service: upgrade
verify_cluster_health: true
- test:
name: Verify DBR feature enabled on upgraded cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test case present for this upgrade path, in only one place .
Can you please recheck.

Copy link
Contributor

mergify bot commented Jan 21, 2025

"This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes?"

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -62,26 +62,16 @@ tests:
name: deploy cluster

# kafka broker type broker with persistent flag enabled
- test:
Copy link

@hmaheswa hmaheswa Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anrao19 pls retain this testcase as polarion id is different in different suites
you may remove them from upgrade suite

@@ -302,18 +300,6 @@ tests:
verify-io-on-site: ["ceph-pri"]
config-file-name: test_Mbuckets_with_Nobjects_compression.yaml

- test:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anrao19 These tests may be duplicates but added to test with cephadm rgw ssl gen_cert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase RGW Rados Gateway tfa-issue-fix TFA automation issue fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants