Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Test File for all CephFS Volume Ops #4391

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

hkadam134
Copy link
Contributor

Description

Create a common test file to add all volume-related test operations.

Latest Run :
http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-TRA414/

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

@hkadam134 hkadam134 force-pushed the volume-test-enh branch 3 times, most recently from eb06009 to d228dc9 Compare January 20, 2025 20:46
Signed-off-by: Hemanth <[email protected]>
Signed-off-by: hkadam134 <[email protected]>
Copy link
Contributor

@AmarnatReddy AmarnatReddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hemanth,

I noticed that there are a few commented lines in tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_test_volume.py.

Are those lines still required?

@hkadam134
Copy link
Contributor Author

Hi Hemanth,

I noticed that there are a few commented lines in tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_test_volume.py.

Are those lines still required?

Yes, Amar. They are still needed. I think Mani had filed a bug for one of the scenarios.

@Manimaran-MM
Copy link
Contributor

Hi Hemanth,
I noticed that there are a few commented lines in tests/cephfs/cephfs_vol_management/cephfs_vol_mgmt_test_volume.py.
Are those lines still required?

Yes, Amar. They are still needed. I think Mani had filed a bug for one of the scenarios.

Bug ID - https://bugzilla.redhat.com/show_bug.cgi?id=2335775

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 24, 2025
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hkadam134, Manimaran-MM

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 3f817f2 into red-hat-storage:main Jan 24, 2025
5 of 6 checks passed
@Manimaran-MM Manimaran-MM mentioned this pull request Jan 27, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Add this label when the PR is good to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants