Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.18] MCG Bucket Notifications - add advanced tests, improvements and fixes #11260

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sagihirshfeld
Copy link
Contributor

This PR adds the following tests to test_bucket_notifications.py:

1. test_multi_notif_event_types: check that other operations besides PutObject result in the expected notificaitons
2. test_multiple_bucket_notifs_setups: verify that MCG can handle bucket notifications configurations, where different buckets are each sending notifications to a separate Kafka topic.
3. test_bucket_notifs_shared_topic: test that multiple buckets can send their notifications to the same Kafka topic

Additionally, the following fixes were made:

  • A typo error in delete_object_tags
  • Skip decorators have been added to the TestBucketNotifications class. Any deployment that might have an issue with external networking have been skipped because setting up Kafka requires such access.
  • Typos in test_bucket_notifications.py
  • The polarion IDs of test_bucket_notifications[default-logs-pvc] and test_bucket_notifications[provided-logs-pvc]

And finally, the following improvements/additions have been made:

  • The costly health checks in BucketNotificationsManager::add_notif_conn_to_noobaa_cr has been replaced by a simpler one from a static method from the MCG class.
  • An option to skip the wait/health check in BucketNotificationsManager::add_notif_conn_to_noobaa_cr and BucketNotificationsManager::put_bucket_notification have been added.
  • Exception handling has been improved at test_bucket_notifications to show what events are missing from the notifications.
  • The function-scoped add_env_vars_to_noobaa_core fixture have been added to conftest.py

Signed-off-by: Sagi Hirshfeld <[email protected]>
@sagihirshfeld sagihirshfeld added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Jan 29, 2025
@sagihirshfeld sagihirshfeld self-assigned this Jan 29, 2025
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link and removed size/L PR that changes 100-499 lines do-not-merge/work-in-progress labels Jan 29, 2025
@sagihirshfeld sagihirshfeld changed the title [4.18] MCG Bucket Notifications - add advanced tests and add improvements and fixes [4.18] MCG Bucket Notifications - add advanced tests,improvements and fixes Jan 29, 2025
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 29, 2025
@sagihirshfeld sagihirshfeld changed the title [4.18] MCG Bucket Notifications - add advanced tests,improvements and fixes [4.18] MCG Bucket Notifications - add advanced tests, improvements and fixes Jan 29, 2025
Signed-off-by: Sagi Hirshfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress MCG Multi Cloud Gateway / NooBaa related issues Needs Testing Run tests and provide logs link size/L PR that changes 100-499 lines Squad/Red
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant