Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new test case for bucketclass NSS creation with Cache via CLI #11283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ypersky1980
Copy link
Contributor

@ypersky1980 ypersky1980 commented Feb 1, 2025

This PR contains adding a new test case for bucketclass NSS creation with Cache via CLI, following issue ##11128 from the backlog.

@ypersky1980 ypersky1980 requested review from a team as code owners February 1, 2025 22:00
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Feb 1, 2025
Copy link

openshift-ci bot commented Feb 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ypersky1980 ypersky1980 added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Feb 1, 2025
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ypersky-vm5
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_namespace_crd.py::TestNamespace::test_namespace_bucket_creation_crd[RGW-CLI-Cache]
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@ypersky1980 ypersky1980 changed the title Adding a new test case for bucketclass NSS creation via CLI Adding a new test case for bucketclass NSS creation with Cache via CLI Feb 2, 2025
@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Feb 2, 2025
Signed-off-by: Yulia Persky <[email protected]>
marks=[
tier1,
on_prem_platform_required,
pytest.mark.polarion_id("OCS-2407"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new polarion item and reference it here instead of this one - this one doesn't match the test:

OCS-2407 - Create MCG namespace bucket from RGW resource

self.exec_mcg_cmd(cmd)
elif namespace_policy_type == constants.NAMESPACE_POLICY_TYPE_CACHE.lower():
cmd += f" --hub-resource={namestores_name_str}"
cmd += " --backingstores=noobaa-default-backing-store"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmd += " --backingstores=noobaa-default-backing-store"
cmd += " --backingstores=constants.DEFAULT_NOOBAA_BACKINGSTORE"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCG Multi Cloud Gateway / NooBaa related issues size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants