Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades ocs-operator dependency #126

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented Apr 1, 2024

Upgrades ocs-operator dep post .pb changes in #2534

@raaizik
Copy link
Contributor Author

raaizik commented Apr 1, 2024

/cc @leelavg

@openshift-ci openshift-ci bot requested a review from leelavg April 1, 2024 12:03
@raaizik
Copy link
Contributor Author

raaizik commented Apr 1, 2024

/cc @Madhu-1

@openshift-ci openshift-ci bot requested a review from Madhu-1 April 1, 2024 12:04
@leelavg
Copy link
Contributor

leelavg commented Apr 1, 2024

Pls update the commit, PR summary and description.

  1. You might've not performed all the changes in go.mod and commit should reflect that, like, godeps: updated ocs-operator dependency
  2. PR summary Various modules upgrade -> Update ocs-operator dependency for new proto definitions
  3. PR description can be like, Updated ocs-operator dependency to pull in latest proto changes from X

It's fine if you want to go w/ any other phrasing, however the intent is to be clear why is the requirement for dependency upgrade and what is being done.

@raaizik raaizik force-pushed the export-name-deps branch from 5db718b to 6c778ae Compare April 1, 2024 12:25
@raaizik raaizik changed the title Various modules upgrade Upgrades ocs-operator dependency Apr 1, 2024
Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, raaizik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d7091e0 into red-hat-storage:main Apr 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants