[fusion-hci-4.14] storageClassRequest: move away from status as source of truth #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose A. Rivera <[email protected]> (cherry picked from commit 7c5d46b)
Signed-off-by: Jose A. Rivera <[email protected]> (cherry picked from commit 3ad7bbf)
this PR updates the svg to have a consistent naming scheme and fetch the resources via ownerReference instead of looking at the status for the source of truth Signed-off-by: Rewant Soni <[email protected]> (cherry picked from commit f5770d8)
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1600777
into
red-hat-storage:fusion-hci-4.14
7 checks passed
nb-ohad
pushed a commit
that referenced
this pull request
Feb 8, 2024
[fusion-hci-4.14] storageClassRequest: move away from status as source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual cherry-pick of one commit from #2449. the diff from #2449 is we aren't taking the unit test file which doesn't exist in fusion-hci-4.14 branch and different pr introduced that in main.
this also contains two commits from #2249 which was a refactor of function signature and logging update.