Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ObcQuotaObjectsAlert overlapping with ObcQuotaObjectsExhausedAlert #2472

Conversation

aruniiird
Copy link
Contributor

Since queries for both ObcQuotaObjectsAlert and
ObcQuotaObjectsExhausedAlert are same, we don't require both the alerts to be fired at the same time.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2257949

@aruniiird aruniiird force-pushed the prevent-obcquota-alert-overlapping branch 2 times, most recently from 7db1b6d to bdd5e06 Compare March 8, 2024 07:23
@iamniting
Copy link
Member

@aruniiird Can you pls fix a commit lint issue

Since queries for both ObcQuotaObjectsAlert and
ObcQuotaObjectsExhausedAlert are same, we don't require both the alerts
to be fired at the same time.

Signed-off-by: Arun Kumar Mohan <[email protected]>
@aruniiird aruniiird force-pushed the prevent-obcquota-alert-overlapping branch from bdd5e06 to 3724ece Compare March 27, 2024 07:16
@aruniiird
Copy link
Contributor Author

@aruniiird Can you pls fix a commit lint issue

Done.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9d38bbf into red-hat-storage:main Mar 27, 2024
11 checks passed
@agarwal-mudit
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot

@agarwal-mudit: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-operator#release-4.16 from head openshift-cherrypick-robot:cherry-pick-2472-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.16 and openshift-cherrypick-robot:cherry-pick-2472-to-release-4.16"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants