-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ROOK_CSI_DISABLE_DRIVER for disabling CSI in provider mode #2530
use ROOK_CSI_DISABLE_DRIVER for disabling CSI in provider mode #2530
Conversation
/hold dependents should be merged first. |
2fadf1b
to
bf998ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just to clarify, I did a hold as we need to first push d/s rook bundle and then reference the bundle tag in here before unholding. |
Signed-off-by: Leela Venkaiah G <[email protected]>
bf998ad
to
694bf3d
Compare
Referred bundle should have the changes done in this PR reflected as below (absence of old keys and presence of new key):
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa, leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
493179c
into
red-hat-storage:main
when ocs is running in provider mode ocs-client-operator manages CSI and this commit adds a key/value for rook to make sure that rook doesn't reconcile CSI at all.
Depends on red-hat-storage/rook#600, red-hat-storage/rook#601
fixes: #2526