rbd: update rbd sc for topology provisioning

[parth-gr]

with new fix at csi ceph/ceph-csi#4459 we dont need the pool parameter dependency from the storageclass So removing it

[parth-gr]

/cc @malayparida2000 @Madhu-1

[Madhu-1]

LGTM, please test the changes to ensure it works as expected

[parth-gr]

Rook Pr should get merged first rook/rook#13977, as it has the json changes

[malayparida2000]

/lgtm
Please ensure testing this before merge.

cc @iamniting

[iamniting]

/hold

@parth-gr adding a hold for testing pls remove it once you are done with the testing.

Also pls look at the external cluster case as well.

[parth-gr]

There is a bug for internal mode, adding a fix in second commit
Tested:

parameters:
  clusterID: openshift-storage
  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
  csi.storage.k8s.io/fstype: ext4
  csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
  csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
  csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
  imageFeatures: layering,deep-flatten,exclusive-lock,object-map,fast-diff
  imageFormat: "2"
  topologyConstrainedPools: |-
    [
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack0",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack0"
          }
        ]
      },
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack1",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack1"
          }
        ]
      },
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack2",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack2"
          }
        ]
      }
    ]

[parth-gr]

/unhold

[malayparida2000]

There is a bug for internal mode, adding a fix in second commit Tested:

parameters:
  clusterID: openshift-storage
  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
  csi.storage.k8s.io/fstype: ext4
  csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
  csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
  csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
  imageFeatures: layering,deep-flatten,exclusive-lock,object-map,fast-diff
  imageFormat: "2"
  topologyConstrainedPools: |-
    [
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack0",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack0"
          }
        ]
      },
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack1",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack1"
          }
        ]
      },
      {
        "poolName": "ocs-storagecluster-cephblockpool-rack2",
        "domainSegments": [
          {
            "domainLabel": "rack",
            "value": "rack2"
          }
        ]
      }
    ]

Let's squash to a single commit, the bug is basically related to this only

[parth-gr]

Done

[malayparida2000]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, parth-gr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment