support namedPoolSpec for filesystem Metadatapool #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp98
changed the title
iamniting
requested changes
Jan 10, 2025
sp98
force-pushed
the
namedPoolSpec
branch
2 times, most recently
from
032bb82 to
ca5c728
Compare
Updated github.com/rook/rook/pkg/apis to latest version. This resulted in an error with filesystem metadataspec using `NamedPoolSpec` instead of `PoolSpec`. This PR updates the api pkg and fixes this issue. Signed-off-by: Santosh Pillai <[email protected]>
done. |
iamniting
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 9ae10c8
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
github.com/rook/rook/pkg/apisto latest version. This resulted in an error with filesystemmetadataPoolusingNamedPoolSpecinstead ofPoolSpec. This PR updates the api pkg and fixes this issue. This rook upstream PR introduced thenamedPoolSpecfor FilesystemMetadataPool