Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1357:[release-4.18] Avoid reconciling rook-ceph-operator-config via the external controller #2971

Merged
merged 2 commits into from
Jan 21, 2025
Merged

DFBUGS-1357:[release-4.18] Avoid reconciling rook-ceph-operator-config via the external controller #2971

merged 2 commits into from
Jan 21, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2970

/assign iamniting

@iamniting
Avoid reconciling rook-ceph-operator-config via the external controller
7ed0371 
The rook-ceph-operator-config ConfigMap is managed by the
OCSInitialization controller and should only be reconciled
by it. This ensures consistency and prevents duplicate handling.

It should be reconciled from OCSInitialization only.

Signed-off-by: Nitin Goyal <[email protected]>
@iamniting
Remove ROOK_CSI_ENABLE_CEPHFS key from rook-ceph-operator-config CM
09896a1 
The ROOK_CSI_ENABLE_CEPHFS key was set in the external mode within the
rook-ceph-operator-config ConfigMap. However, it should have been
removed when transitioning from rook-ceph-operator-config to
ocs-operator-config. The rook-ceph-operator-config ConfigMap is now
retained only for customer modifications.

This code can be safely removed in the next release, as it only require
to run once to delete the key.

Signed-off-by: Nitin Goyal <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 21, 2025
Merged
@iamniting iamniting changed the title [release-4.18] Avoid reconciling rook-ceph-operator-config via the external controller DFBUGS-1357:[release-4.18] Avoid reconciling rook-ceph-operator-config via the external controller Jan 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1357](https://issues.redhat.com//browse/DFBUGS-1357), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

This is an automated cherry-pick of #2970

/assign iamniting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 3a27363 into red-hat-storage:release-4.18 Jan 21, 2025
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1357](https://issues.redhat.com//browse/DFBUGS-1357): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1357](https://issues.redhat.com//browse/DFBUGS-1357) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2970

/assign iamniting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @iamniting