metrics:set metrics if not nil

Signed-off-by: rakeshgm <[email protected]>
red-hat-storage · Oct 4, 2023 · 1ff72a8 · 1ff72a8
1 parent 1521079
commit 1ff72a8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/controllers/drplacementcontrol_controller.go b/controllers/drplacementcontrol_controller.go
@@ -1506,7 +1506,9 @@ func (r *DRPlacementControlReconciler) updateResourceCondition(
 		drpc.Status.ResourceConditions = rmn.VRGConditions{}
 		drpc.Status.LastGroupSyncTime = nil
 
-		r.setLastSyncTimeMetric(syncmetric, nil, log)
+		if syncmetric != nil {
+			r.setLastSyncTimeMetric(syncmetric, nil, log)
+		}
 	} else {
 		drpc.Status.ResourceConditions.ResourceMeta.Kind = vrg.Kind
 		drpc.Status.ResourceConditions.ResourceMeta.Name = vrg.Name
@@ -1522,7 +1524,9 @@ func (r *DRPlacementControlReconciler) updateResourceCondition(
 		drpc.Status.ResourceConditions.ResourceMeta.ProtectedPVCs = protectedPVCs
 		drpc.Status.LastGroupSyncTime = vrg.Status.LastGroupSyncTime
 
-		r.setLastSyncTimeMetric(syncmetric, vrg.Status.LastGroupSyncTime, log)
+		if syncmetric != nil {
+			r.setLastSyncTimeMetric(syncmetric, vrg.Status.LastGroupSyncTime, log)
+		}
 	}
 }